{"id":3351,"date":"2016-03-06T11:35:30","date_gmt":"2016-03-06T10:35:30","guid":{"rendered":"https:\/\/www.devco.net\/?p=3351"},"modified":"2016-03-16T11:25:48","modified_gmt":"2016-03-16T10:25:48","slug":"params-pp-in-puppet-4","status":"publish","type":"post","link":"https:\/\/www.devco.net\/archives\/2016\/03\/06\/params-pp-in-puppet-4.php","title":{"rendered":"params.pp in Puppet 4"},"content":{"rendered":"<p>I <a href=\"https:\/\/www.devco.net\/archives\/2013\/12\/09\/the-problem-with-params-pp.php\">do not like the params.pp pattern<\/a>.  Puppet 4 has brought native <a href=\"https:\/\/www.devco.net\/archives\/2016\/01\/08\/native-puppet-4-data-in-modules.php\">Data in Modules<\/a> that&#8217;s pretty awesome and to a large extend it removes the traditional need for <em>params.pp<\/em>.<\/p>\n<p>Thing is, we kind of do still need some parts of params.pp.  To understand this we have to consider what the areas of concern params.pp has in Puppet world:<\/p>\n<ul>\n<li>Holds data, often in large if or case statements that ultimately resemble hiera data<\/li>\n<li>Derives new data using logic based on situation specific data like facts<\/li>\n<li>Validates data is valid. This was kind of all over the place and not in params.pp since it&#8217;s not parameterised generally.  But it&#8217;s closely related.<\/li>\n<\/ul>\n<p>Points 1 and 3 are roughly sorted out by Puppet 4 types and data in modules, but what about the 2nd point and to some extend more complex data validation that falls outside of the type system?<\/p>\n<p>Before I start looking at how to derive data though I&#8217;ll take a look at the new function API in Puppet 4.<\/p>\n<p><H3>Native Functions<\/H3><br \/>\nPuppet has always allowed us to write functions but they needed to be in Ruby and nothing else.  This isn&#8217;t really great.  The message is kind of: <\/p>\n<blockquote><p>\nPuppet has a DSL for managing systems, we think it&#8217;s awesome and can do everything you need.  But in order to use it you have to learn 2 programming languages with different models.\n<\/p><\/blockquote>\n<p>And I always felt the same about the general suggestion to write ENCs etc, luckily not something we hear much these days.<\/p>\n<p>And they had a few major issues:<\/p>\n<ul>\n<li>They do not work right in environments, just like custom providers and types do not.  This is a showstopper bug as environments have become indispensable in modern Puppet use.<\/li>\n<li>They are not namespaced. This is a showstopper for putting them on the forge.<\/li>\n<\/ul>\n<p>The Puppet 4 functions API fix this, you can write functions in the native DSL and they work fine in environments.  The Puppet 4 DSL with it&#8217;s loops and blocks and so forth have matured enough that it can do a lot of the things I&#8217;d need to do for deriving data from other data.<\/p>\n<p>They live in your module in the <em>functions<\/em> directory, they&#8217;re namespaced and environment safe:<\/p>\n<pre lang=\"puppet\">\r\nfunction mymod::myfunc(Fixnum $input) {\r\n  $input * 2\r\n}\r\n<\/pre>\n<p>And you&#8217;d use this like any other function: <em>$x = mymod::myfunc(10)<\/em>.  Simple stuff, whatever is the last value is returned like in Ruby.<\/p>\n<p><strong>Update:<\/strong> these have now been documented in the <a href=\"http:\/\/docs.puppetlabs.com\/puppet\/latest\/reference\/lang_write_functions_in_puppet.html\">Puppet Labs docs<\/a><br \/>\n<H3>Derived Data in Puppet 4<\/H3><br \/>\nSo we&#8217;re finally where I can show my preferred method for deriving data in Puppet 4, and that&#8217;s to use a native function.<\/p>\n<p>As an example we&#8217;ll stick with Apache but this time a wrapper for the main class. From the <a href=\"https:\/\/www.devco.net\/archives\/2016\/02\/28\/the-resource-wrapper-pattern-in-puppet-4.php\">previous blog post<\/a> you&#8217;ll remember (or if not please read that post) that we wrapped the <em>puppetlabs-apache<\/em> module to create our own <em>vhost<\/em> define.  Here I&#8217;ll show a wrapper for the main apache class.<\/p>\n<pre lang=\"puppet\">\r\nclass site::apache(\r\n  Boolean $passenger = false,\r\n  Hash $apache = {}\r\n  Hash $module_options = {}\r\n) {\r\n  if $passenger {\r\n    $_passenger_defaults = {\r\n      \"passenger_max_pool_size\" => site::apache::passenger_pool_size(),\r\n      # ...\r\n    }\r\n\r\n    class{\"apache::mod::passenger\":\r\n      * => $_passenger_defaults + site::fetch($module_options, \"passenger\", {})\r\n    }\r\n  }\r\n\r\n  $defaults = {\r\n    \"default_vhost\" => false,\r\n    # ....\r\n  }\r\n\r\n  class{\"apache\":\r\n    * => $defaults + $apache\r\n  }\r\n}\r\n<\/pre>\n<p>Here I have a wrapper that does the basic Apache configuration with some overridable defaults via <em>$apache<\/em> and I have a way to configure Passenger again with overridable defaults via <em>$module_options[&#8220;passenger&#8221;]<\/em>.<\/p>\n<p>The Passenger part uses 2 functions: <em>site::apache::passenger_poolsize<\/em> and <em>site::fetch<\/em>. These are name spaced to the <em>site<\/em> module and are functions that you can see below:<\/p>\n<p>First the <em>site:apache::passenger_poolsize<\/em> that follows typical community guidelines for the pool size based on core count, it&#8217;s also aware if the machine is virtual or physical.  This is a good example of derived data that would be impossible to do using just Hiera &#8211; and so simply does not have a place there.<\/p>\n<pre lang=\"puppet\">\r\nfunction site::apache::passenger_poolsize {\r\n  if $is_virtual {\r\n    $multiplier = 1.5\r\n  } else {\r\n    $multiplier = 2\r\n  }\r\n\r\n  floor($facts[\"processors\"][\"count\"] * $multiplier)\r\n}\r\n<\/pre>\n<p>And this is <em>site::fetch<\/em> that&#8217;s like Ruby&#8217;s Hash#fetch.  stdlib will soon have <em>dig()<\/em> that does something similar.<\/p>\n<pre lang=\"puppet\">\r\nfunction site::fetch(\r\n  Hash $data,\r\n  String $key,\r\n  Data $default\r\n) {\r\n  if $data[$key] {\r\n    $data[$key]\r\n  } else {\r\n    $default\r\n  }\r\n}\r\n<\/pre>\n<h3>Why functions and not inlining the logic?<\/h3>\n<p>This seems like a bit more work than just sticking the <em>site::apache::passenger_poolsize<\/em> logic into the class that&#8217;s calling it so why bother?  The first is obviously that it&#8217;s reusable so if you have anywhere else you might need this logic you could use it.  But the second is about isolation.<\/p>\n<p>I am not a big fan of writing Puppet rspec tests since I tend to shy away from Puppet logic in modules.  But if I have to put logic in modules I&#8217;d like to isolate the logic so I can easily test it in isolation.  I have no idea if rspec-puppet supports these functions yet, but if it did having this logic in as small a package as possible for testing is absolutely the right thing to do.<\/p>\n<p>Further today the function is quite limited, but I can see I might want to expand it later to consider total memory as well as core count.  When that day comes, I only have to edit this function and nothing else.  The potential fallout from logic errors and so forth is neatly contained and importantly I can be fairly sure that this function is used for 1 thing only and changing it&#8217;s internals is something I can safely do &#8211; the things calling it really should not care for it&#8217;s internals.<\/p>\n<p>Early on here I touched on complex validation of data as a possibly thing these functions could solve.  The example here does not really do this, but imagine that for my site I never want to set the passenger_poolsize above some threshold that might relate to the memory on the machine.  Given that this poolsize is user overridable I&#8217;d write a function like <em>site::apache::validate_poolsize<\/em> that takes care of this and fails when needed.<\/p>\n<p>These validations could become very complex and situation specific (ie. based on facts) so this is more than we can expect from a Type system.  Writing validations as native functions is easy and fits in neatly with the DSL.<\/p>\n<h3>Conclusion<\/h3>\n<p>These functions are great, to me they are everything defined types should have been and more.  I think they move Puppet as a whole a huge leap forward in that you can achieve more complex things using just the Puppet DSL and they combine very nicely with the recent <em>epp<\/em> native Puppet based templates.<\/p>\n<p>They fix massive show stopper bugs of environment compatibility and makes sharing modules like this on a forge a lot safer.<\/p>\n<p>Using them in this manner here Puppet 4 can close the loop on all the functionality that <em>params.pp<\/em> had:<\/p>\n<ul>\n<li>Pure data that is hierarchical in nature can <a href=\"https:\/\/www.devco.net\/archives\/2016\/01\/08\/native-puppet-4-data-in-modules.php\">live in modules<\/a>.<\/li>\n<li>Input validation can be done using the data type system.<\/li>\n<li>Derived data can be done in isolation and in a reusable manner using native functions<\/li>\n<\/ul>\n<p>When combined in this manner <em>params.pp<\/em> can be removed completely without any loss of functionality.  Every one of these above points improve significantly on the old pattern.<\/p>\n<p>I could not find docs for the new functions on the Puppet Labs site, hopefully we&#8217;ll see some soon.  <\/p>\n<p>I have a short wishlist for these functions:<\/p>\n<ul>\n<li>I want to be able to specify their return type from functions, I think this is critical.<\/li>\n<li>I want a return() function like in other languages.  I know you can generally do without but sometimes that can lead to some pretty awkward code.<\/li>\n<li>More docs<\/li>\n<\/ul>\n<h3>Bonus: The end of defined types?<\/h3>\n<p>These functions can create resources just like any other manifest can.  This is a big difference from old Ruby functions who had to do all kinds of nasty things, possibly via <em>create_resources<\/em>. But since they can create resources they might be a viable replacement for defined types.<\/p>\n<p>There are a few issues with this idea: The immediate missing part is that you cannot export a function.  Additionally as they are outside of the resource system you couldn&#8217;t do overrides and do any relations on them.  You can&#8217;t say install a package before a vhost made by a function.<\/p>\n<p>The first I don&#8217;t really personally care for since I do not and will never use exported resources.  The 2nd is perhaps a more important issue, from a ordering perspective the MOAR ordering in Puppet 4 helps but for doing notifies and such it might not be that hot.<\/p>\n<p>It&#8217;s a interesting thought experiment though, I think with a bit of work defined types can be deprecated, people want to think of defined types as functions but they aren&#8217;t and this is a hurdle in learning Puppet for newcomers, with some work I think functions can eventually replace defined types.  That&#8217;s a good goal to work toward.<\/p>\n","protected":false},"excerpt":{"rendered":"<p>I do not like the params.pp pattern. Puppet 4 has brought native Data in Modules that&#8217;s pretty awesome and to a large extend it removes the traditional need for params.pp. Thing is, we kind of do still need some parts of params.pp. To understand this we have to consider what the areas of concern params.pp [&hellip;]<\/p>\n","protected":false},"author":2,"featured_media":0,"comment_status":"open","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"_et_pb_use_builder":"","_et_pb_old_content":"","footnotes":""},"categories":[7],"tags":[85,21],"_links":{"self":[{"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/posts\/3351"}],"collection":[{"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/users\/2"}],"replies":[{"embeddable":true,"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/comments?post=3351"}],"version-history":[{"count":20,"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/posts\/3351\/revisions"}],"predecessor-version":[{"id":3427,"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/posts\/3351\/revisions\/3427"}],"wp:attachment":[{"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/media?parent=3351"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/categories?post=3351"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.devco.net\/wp-json\/wp\/v2\/tags?post=3351"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}